-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cicd builds #41
Feature/cicd builds #41
Conversation
89f6ec2
to
ba3b80c
Compare
Required for #20 |
@jeevantelukula Can you help in validating it on your personal fork once |
@aniket-l for reviews |
build workflow works fine. For deploy workflow, there is issue with GITHUB_TOKEN permissions. I would suggest to add permissions block in deploy.yml |
No need to create these artifacts. We don't do anything with them and the repo source is publicly available anyway. Signed-off-by: Randolph Sapp <[email protected]>
Use a matrix to parallelize building the docs for listed DEVFAMILY and OS combinations. Aggregate the results to build an expected pages artifact. Deploy the monolithic artifact to GitHub pages. If any platform fails for any reason, the arguments and logs for that build will be logged under a separate section of this workflow, and the results should not be deployed. Signed-off-by: Randolph Sapp <[email protected]>
ba3b80c
to
a969c60
Compare
@StaticRocket After build.yml executed github-pages artifacts are generated. When deploy.yml executes, it is unable to find the github-pages artifacts in the workflow. |
@StaticRocket Can you checkout |
a969c60
to
bc42838
Compare
@jeevantelukula Can you re-review |
bc42838
to
a969c60
Compare
Example deployment here: https://staticrocket.github.io/processor-sdk-doc/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Automatic builds and deployment to GitHub pages for any updates to the master branch.
Use a matrix to parallelize building the docs for listed DEVFAMILY and
OS combinations. Aggregate the results to build an expected pages
artifact. Deploy the monolithic artifact to GitHub pages.
If any platform fails for any reason, the arguments and logs for that
build will be logged under a separate section of this workflow, and the
results should not be deployed.
Fair warning, I have tested the build and aggregation step, but I am not currently able to test the deployment step as my master branch is still locked up in the codeowners draft. I'd appreciate someone taking a look at this on their fork.