Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Foundational_Components_IPC_J7*: Fix link to Top Level Makefile #4

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

aniket-l
Copy link
Collaborator

Signed-off-by: Aniket Limaye [email protected]

Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the content changes. I'll let @nmenon argue guidelines.

@nmenon
Copy link
Contributor

nmenon commented Oct 28, 2024

rebase on master to get the checkers to run

…k to Top Level Makefile

Link to Top level makefile was broken for J7* platforms.
Fix by using :ref: role instead of hardcoded relative path to html.
https://www.sphinx-doc.org/en/master/usage/referencing.html#cross-referencing-arbitrary-locations

Signed-off-by: Aniket Limaye <[email protected]>
…nd use proper code-block

Fix indentation to 3 spaces

Replace generic literal blocks "::" by code-block directives as applicable
https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block

Signed-off-by: Aniket Limaye <[email protected]>
@aniket-l
Copy link
Collaborator Author

aniket-l commented Oct 28, 2024

rebase on master to get the checkers to run

@nmenon @StaticRocket
Not sure what I am missing here... I seem to have added necessary formatting to the commits

Type commit_signoff check failed => 04a924b2eb59a5baf41d57c4484dc3c4ef52756c 
It doesn't match regex: Signed-off-by:.*[A-Za-z0-9]\s+<[\w\.]+@([\w-]+\.)+[\w-]{2,4}>

Looks to me like below change is needed in the regex matching pattern, to match with the '-' character in email-id?
<[\w\.]+@([\w-]+\.)+[\w-]{2,4}> => <[\w\.\-]+@([\w-]+\.)+[\w-]{2,4}>

@StaticRocket
Copy link
Member

StaticRocket commented Oct 28, 2024

Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.

commit-check/commit-check#184

@shenxianpeng
Copy link

shenxianpeng commented Oct 28, 2024

Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex.

commit-check/commit-check#184

This issue has been resolved.

However, there’s another failure in this run that requires additional permissions in commit-check.yml for pr-comments

permissions:
  contents: write
  pull-requests: write
  repository-projects: write

@StaticRocket
Copy link
Member

@shenxianpeng yeah, that one's on me. I figured that would be required. I'll update the workflow here and your example workflow since it sets the comment flag to true as well.

@StaticRocket StaticRocket requested a review from nmenon October 29, 2024 05:10
@StaticRocket
Copy link
Member

@cshilwant @praneethbajjuri we need another maintainer to sign off on this.

@praneethbajjuri praneethbajjuri merged commit 8009938 into TexasInstruments:master Oct 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants