-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: Foundational_Components_IPC_J7*: Fix link to Top Level Makefile #4
linux: Foundational_Components_IPC_J7*: Fix link to Top Level Makefile #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the content changes. I'll let @nmenon argue guidelines.
b84329c
to
4bd7e2c
Compare
rebase on master to get the checkers to run |
4bd7e2c
to
0ae894d
Compare
…k to Top Level Makefile Link to Top level makefile was broken for J7* platforms. Fix by using :ref: role instead of hardcoded relative path to html. https://www.sphinx-doc.org/en/master/usage/referencing.html#cross-referencing-arbitrary-locations Signed-off-by: Aniket Limaye <[email protected]>
…nd use proper code-block Fix indentation to 3 spaces Replace generic literal blocks "::" by code-block directives as applicable https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block Signed-off-by: Aniket Limaye <[email protected]>
0ae894d
to
04a924b
Compare
@nmenon @StaticRocket
Looks to me like below change is needed in the regex matching pattern, to match with the '-' character in email-id? |
Yeah, that's a bug in the upstream checker. They should not attempt to verify email addresses with regex. |
This issue has been resolved. However, there’s another failure in this run that requires additional permissions in commit-check.yml for
|
@shenxianpeng yeah, that one's on me. I figured that would be required. I'll update the workflow here and your example workflow since it sets the comment flag to true as well. |
@cshilwant @praneethbajjuri we need another maintainer to sign off on this. |
Signed-off-by: Aniket Limaye [email protected]