Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CODEOWNERS #141

Closed
wants to merge 3 commits into from

Conversation

VeeruPrudhvi
Copy link

@VeeruPrudhvi VeeruPrudhvi commented Dec 18, 2024

Update the codeowners file for the default reviewers list.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeeruPrudhvi processor-sdk-doc uses commit-check-action github action that follows conventional commits for commit message.

Hence, we see the Commit Check GitHub workflow failing.
Checkout https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/12391426830?pr=141 for more details

In your case, the commit message can be similar to 56ca25b which is an accepted format & ensures that the workflow passes.

Also, ensure you Sign-off each commit by adding a -s flag with git commit - https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s

@VeeruPrudhvi VeeruPrudhvi changed the title Update CODEOWNERS chore: Update CODEOWNERS Dec 19, 2024
Add self to the list of CODEOWNERS.

Signed-off-by: Prudhvi Veeramachaneni <[email protected]>
jsuhaas22
jsuhaas22 previously approved these changes Dec 19, 2024
Copy link
Contributor

@jsuhaas22 jsuhaas22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeevantelukula
jeevantelukula previously approved these changes Dec 19, 2024
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of unintended changes here due to some git mishap probably. Please no merge commits and no REVERT merge commits either. Just git pull --rebase on master and then force push to the PR branch.

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please plan to address #141 (review)

@VeeruPrudhvi VeeruPrudhvi closed this by deleting the head repository Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.