-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update CODEOWNERS #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VeeruPrudhvi processor-sdk-doc
uses commit-check-action
github action that follows conventional commits for commit message.
Hence, we see the Commit Check GitHub workflow failing.
Checkout https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/12391426830?pr=141 for more details
In your case, the commit message can be similar to 56ca25b which is an accepted format & ensures that the workflow passes.
Also, ensure you Sign-off each commit by adding a -s
flag with git commit
- https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s
Add self to the list of CODEOWNERS. Signed-off-by: Prudhvi Veeramachaneni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d93741e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of unintended changes here due to some git mishap probably. Please no merge commits and no REVERT merge commits either. Just git pull --rebase on master and then force push
to the PR branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please plan to address #141 (review)
Update the codeowners file for the default reviewers list.