-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edgeai-apps-utils: add support to build edgeai-apps-utils package #21
Open
jsuhaas22
wants to merge
1
commit into
TexasInstruments:master
Choose a base branch
from
jsuhaas22:add-edgeai-apps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
This package installs to two locations: | ||
|
||
1. the .so file is installed in /usr/lib/ | ||
2. the includes are installed in /usr/include/edgeai-apps-utils/ | ||
|
||
Further, the entire source code is cloned in /opt/. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
edgeai-apps-utils (0.1+git20240205+8e84be376-1) bookworm; urgency=low | ||
|
||
* Initial release. | ||
|
||
-- Suhaas Joshi <[email protected]> Wed, 14 Feb 2024 05:49:56 +0000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
Source: edgeai-apps-utils | ||
Section: libs | ||
Priority: optional | ||
Maintainer: Suhaas Joshi <[email protected]> | ||
Build-Depends: cmake, debhelper-compat (= 13) | ||
Standards-Version: 4.5.1 | ||
Homepage: https://git.ti.com/cgit/edgeai/edgeai-apps-utils | ||
Rules-Requires-Root: no | ||
|
||
Package: libedgeai-apps-utils | ||
Section: libs | ||
Architecture: any | ||
Depends: ${misc:Depends}, ${shlibs:Depends} | ||
Description: EdgeAI Apps Utils | ||
EdgeAI Apps Utils implements ARMv8 neon optimized utility functions | ||
and also NV12 post process utility functions. | ||
|
||
Package: libedgeai-apps-utils-dev | ||
Section: libdevel | ||
Architecture: any | ||
Depends: ${misc:Depends}, ${shlibs:Depends} libedgeai-apps-utils | ||
Description: EdgeAI Apps Utils | ||
EdgeAI Apps Utils implements ARMv8 neon optimized utility functions | ||
and also NV12 post process utility functions. | ||
. | ||
This package contains development files for libedgeai-apps-utils. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ | ||
Upstream-Name: edgeai-apps-utils | ||
Upstream-Contact: Texas Instruments | ||
Source: https://git.ti.com/cgit/edgeai/edgeai-apps-utils | ||
|
||
Files: * | ||
Copyright: 2023 Texas Instruments Incorporated | ||
License: BSD-3-Clause | ||
not granted herein. | ||
. | ||
Limited License. | ||
. | ||
Texas Instruments Incorporated grants a world-wide, royalty-free, non-exclusive | ||
license under copyrights and patents it now or hereafter owns or controls to make, | ||
have made, use, import, offer to sell and sell ("Utilize") this software subject to the | ||
terms herein. With respect to the foregoing patent license, such license is granted | ||
solely to the extent that any such patent is necessary to Utilize the software alone. | ||
The patent license shall not apply to any combinations which include this software, | ||
other than combinations with devices manufactured by or for TI ("TI Devices"). | ||
No hardware patent is licensed hereunder. | ||
. | ||
Redistributions must preserve existing copyright notices and reproduce this license | ||
(including the above copyright notice and the disclaimer and (if applicable) source | ||
code license limitations below) in the documentation and/or other materials provided | ||
with the distribution | ||
. | ||
Redistribution and use in binary form, without modification, are permitted provided | ||
that the following conditions are met: | ||
. | ||
* No reverse engineering, decompilation, or disassembly of this software is | ||
permitted with respect to any software provided in binary form. | ||
. | ||
* any redistribution and use are licensed by TI for use only with TI Devices. | ||
. | ||
* Nothing shall obligate TI to provide you with source code for the software | ||
licensed and provided to you in object code. | ||
. | ||
If software source code is provided to you, modification and redistribution of the | ||
source code are permitted provided that the following conditions are met: | ||
. | ||
* any redistribution and use of the source code, including any resulting derivative | ||
works, are licensed by TI for use only with TI Devices. | ||
. | ||
* any redistribution and use of any object code compiled from the source code | ||
and any resulting derivative works, are licensed by TI for use only with TI Devices. | ||
. | ||
Neither the name of Texas Instruments Incorporated nor the names of its suppliers | ||
. | ||
may be used to endorse or promote products derived from this software without | ||
specific prior written permission. | ||
. | ||
DISCLAIMER. | ||
. | ||
THIS SOFTWARE IS PROVIDED BY TI AND TI'S LICENSORS "AS IS" AND ANY EXPRESS | ||
OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES | ||
OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. | ||
IN NO EVENT SHALL TI AND TI'S LICENSORS BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, | ||
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE | ||
OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
OF THE POSSIBILITY OF SUCH DAMAGE. |
2 changes: 2 additions & 0 deletions
2
edgeai-apps-utils/suite/bookworm/debian/libedgeai-apps-utils-dev.install
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
usr/include/* /usr/include | ||
usr/lib/*.so /usr/lib |
2 changes: 2 additions & 0 deletions
2
edgeai-apps-utils/suite/bookworm/debian/libedgeai-apps-utils-dev.lintian-overrides
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
initial-upload-closes-no-bugs | ||
truetype-font-prohibits-installable-embedding |
1 change: 1 addition & 0 deletions
1
edgeai-apps-utils/suite/bookworm/debian/libedgeai-apps-utils.install
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
usr/lib/*.so.* /usr/lib |
2 changes: 2 additions & 0 deletions
2
edgeai-apps-utils/suite/bookworm/debian/libedgeai-apps-utils.lintian-overrides
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
initial-upload-closes-no-bugs | ||
package-name-doesnt-match-sonames |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/usr/bin/make -f | ||
|
||
export SOC=am62x | ||
|
||
%: | ||
dh $@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
3.0 (quilt) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/bin/bash | ||
|
||
export git_repo="https://git.ti.com/git/edgeai/edgeai-apps-utils.git" | ||
export custom_build=false | ||
export require_root=true | ||
export last_tested_commit="8e84be376afb7fdb8aa16d9d048fa068f9837fa2" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here is a problem, for some reason they made part of this program SoC specific, instead of just doing runtime detection of the platform. This means they need a different binary compiled for each and every SoC. And you would then need a different package for each supported SoC. That is bad software design. They might get away with it in Yocto where the whole system is rebuild for a given machine, but not normal distros.
Let's fix this at the source, go let the edgeai-apps-utils folks know this won't work. They need fix their compile-time hard-coding and instead do runtime detection, just like we do in k3conf. They can use that as an example even.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
I talked to the edgeai team. They have agreed to do it, but they said that it will require some work. They said that it may not be possible in the near-future, but they'll try to squeeze it in 9.2 release.