BuildByConstructor implementation #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der to invoke an automated build of the object via a constructor.
|
Locally all of the List tests appear to be failing; I don't have access to the CI server to see if it excludes those tests, but the test I added passes correctly. If I get time I can look into why the List tests are failing, but they were failing before this pull request. |
|
It's ok I know why they are failing and can fix it. you can see the CI server btw - you just have to log in as guest We're going to pull in your implementation in a slightly different way as part of another PR at some point soon because it ties in nicely with something else we were trying to achieve (nice timing!) |
|
Sweet, I'll close this off pull request then :) |
|
This PR was merged as part of #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation to build the object via its constructor with the most parameters. Should address #24