Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for partitioned BZ2 tables in Hive #341

Open
wants to merge 1 commit into
base: sprint-38
Choose a base branch
from

Conversation

cawallin
Copy link

@cawallin cawallin commented Sep 7, 2016

In the past, partitioned BZ2 tables in Hive failed. The error now is not reproducable.

@@ -199,15 +206,75 @@ public void testCreatePartitionedTableAs(StorageFormat storageFormat)
query(createTableAsSelect);

// SELECT FROM TABLE
assertSelect("select sum(tax), sum(discount), sum(length(returnflag)) from %s", tableName);
assertSelect("select sum(tax), sum(discount), sum(length(returnflag)) from %s", tableName, "tpch." + TPCH_SCHEMA + ".lineitem");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract catalog name to a constant?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can extract this whole bit to a constant

In the past, partitioned BZ2 tables in Hive failed. The error now is not reproducable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants