Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bk-components): add retry for timeout of core-api and bkauth #88

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(bk-components): add retry for timeout of core-api and bkauth #88

merged 1 commit into from
Nov 13, 2024

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Nov 12, 2024

Description

bkauth和core-api的性能都非常好，一般10ms以内；但是由于网络问题/db 偶发查询慢，会导致偶发的 timeout；

  1. 将默认超时时间减半
  2. 增加一次重试, 解决偶发网络问题

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken wklken requested a review from Han-Ya-Jun November 12, 2024 08:57
Han-Ya-Jun
Han-Ya-Jun approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@Han-Ya-Jun Han-Ya-Jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wklken wklken merged commit b56757a into TencentBlueKing:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piglei piglei piglei left review comments

@Han-Ya-Jun Han-Ya-Jun Han-Ya-Jun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wklken @piglei @Han-Ya-Jun