Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bk-cache-fallback/init.lua): if acquire lock timeout, try to get … #87

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix(bk-cache-fallback/init.lua): if acquire lock timeout, try to get … #87

merged 4 commits into from
Nov 13, 2024

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Nov 11, 2024 •
edited
Loading

…data from shared_dict

Description

fix: bk-cache-fallback 如果 获取锁 失败，不直接返回，而是先尝试从shared_dict 获取二级缓存数据

场景：获取到锁的request，请求第三方一直没有返回，导致此时并发的其他请求全部acquire lock timeout， 调用方感知到错误

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken wklken marked this pull request as ready for review November 12, 2024 02:27
@wklken wklken requested a review from Han-Ya-Jun November 12, 2024 02:28
@wklken wklken merged commit 55eb657 into TencentBlueKing:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piglei piglei piglei left review comments

@Han-Ya-Jun Han-Ya-Jun Han-Ya-Jun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wklken @piglei @Han-Ya-Jun