Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bk-auth-verify): add app_code/app_secret length check #70

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix(bk-auth-verify): add app_code/app_secret length check #70

merged 3 commits into from
Nov 30, 2023

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Nov 27, 2023 •
edited
Loading

Description

  • 调用bkauth校验app_code/app_secret前, 提前 check 长度
  • 修复 uri 参数中使用中文导致 404 问题

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken wklken merged commit a71cfd9 into TencentBlueKing:master Nov 30, 2023
3 checks passed
@wklken wklken deleted the fix_bkauth_app_code_app_secret_check branch November 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhu327 zhu327 zhu327 approved these changes

@alex-smile alex-smile Awaiting requested review from alex-smile

@Han-Ya-Jun Han-Ya-Jun Awaiting requested review from Han-Ya-Jun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wklken @zhu327