Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

允许不从请求参数获取认证参数 #65

Merged

Conversation

alex-smile
Copy link
Contributor

Description

Fixes # (issue)

Checklist

  • 填写 PR 描述及相关 issue (write PR description and related issue)
  • 代码风格检查通过 (code style check passed)
  • PR 中包含单元测试 (include unit test)
  • 单元测试通过 (unit test passed)
  • 本地开发联调环境验证通过 (local development environment verification passed)

@wklken
Copy link
Collaborator

wklken commented Nov 6, 2023

录个issue:

  • 通过页面创建->导出->导入, 需要支持设置这两个新增字段
  • apigw-manager的文档中, 支持用户配置这两个字段

@alex-smile
Copy link
Contributor Author

录个issue:

  • 通过页面创建->导出->导入, 需要支持设置这两个新增字段
  • apigw-manager的文档中, 支持用户配置这两个字段

已记录

src/apisix/plugins/bk-define/context-api-bkauth.lua Outdated Show resolved Hide resolved
src/apisix/plugins/bk-delete-sensitive.lua Outdated Show resolved Hide resolved
@wklken wklken self-requested a review November 6, 2023 12:07
@wklken
Copy link
Collaborator

wklken commented Nov 6, 2023

先不合并, 下下个版本处理

@wklken
Copy link
Collaborator

wklken commented Nov 10, 2023

  • 需要更新下 iwiki中对应插件的文档
  • 需要在测试环境, 发布dashboard以及apisix, 验证生效 (重点验证对现在的存量无影响, 对页面新建的都有参数, 对导入的都无影响)
  • 确认: dashboard 导出, 导入到另一个网关, 这个配置能不能带上? (即,确保通过导出-导入链路的能正常灌入)

@alex-smile
Copy link
Contributor Author

alex-smile commented Nov 11, 2023

  • 需要更新下 iwiki中对应插件的文档
  • 需要在测试环境, 发布dashboard以及apisix, 验证生效 (重点验证对现在的存量无影响, 对页面新建的都有参数, 对导入的都无影响)
  • 确认: dashboard 导出, 导入到另一个网关, 这个配置能不能带上? (即,确保通过导出-导入链路的能正常灌入)
    1. 已更新 iwiki 对应插件文档
    1. todo: 待出包后,添加新的功能测试用例,以及测试现有功能测试用例
    1. done: 1.13 版本已可以通过 openapi 修改网关的配置 allow_delete_sensitive_params/allow_auth_from_params,用户在 yaml 中添加这两个配置项即可

@wklken wklken merged commit 04ea6d4 into TencentBlueKing:master Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants