fix(plugin/bk-cache-fallback): bk-cache-fallback use the separate sha…

…red_dict for lock
TencentBlueKing · Sep 19, 2023 · 45dac8f · 45dac8f
1 parent ca182a3
commit 45dac8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/apisix/plugins/bk-cache-fallback/init.lua b/src/apisix/plugins/bk-cache-fallback/init.lua
@@ -36,9 +36,8 @@ local ngx_shared = ngx.shared
 
 local fallback_missing_err = "create_obj_funcs failed and got no data in the shared_dict for fallback"
 
--- NOTE: here we use the same shared_dict as apisix lrucache-lock
---       if this become a problem in the future, we should apply and use our own bk-lrucache-lock
-local lock_shdict_name = "lrucache-lock"
+-- NOTE: change to separate shared_dict, avoid use the name with `lurcache-lock`
+local lock_shdict_name = "plugin-bk-cache-fallback-lock"
 if ngx.config.subsystem == "stream" then
     lock_shdict_name = lock_shdict_name .. "-" .. ngx.config.subsystem
 end

diff --git a/src/apisix/tests/conf/nginx.conf b/src/apisix/tests/conf/nginx.conf
@@ -3,6 +3,7 @@ lua_shared_dict plugin-limit-conn 1m;
 lua_shared_dict prometheus-metrics 1m;
 lua_shared_dict plugin-bk-permission 1m;
 lua_shared_dict plugin-bk-cache-fallback 1m;
+lua_shared_dict plugin-bk-cache-fallback-lock 1m;
 # for unittest, bk-cache-fallback/init.lua, case ok/fail/ok->fail
 lua_shared_dict plugin-bk-cache-fallback-ok 1m;
 lua_shared_dict plugin-bk-cache-fallback-fail 1m;