Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复差量同步主机忽略内网IP变更场景 (closed #2504) #2509

Open
wants to merge 1 commit into
base: v2.4.8-dev
Choose a base branch
from

Conversation

Huayeaaa
Copy link
Collaborator

@Huayeaaa Huayeaaa commented Dec 5, 2024

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@Huayeaaa Huayeaaa requested a review from wyyalt December 5, 2024 10:26
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2504 branch 4 times, most recently from 15ae56c to 720d294 Compare December 5, 2024 12:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.4.8-dev@847a5d7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
apps/node_man/periodic_tasks/sync_cmdb_host.py 80.64% 6 Missing ⚠️
apps/node_man/serializers/job.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             v2.4.8-dev    #2509   +/-   ##
=============================================
  Coverage              ?   75.30%           
=============================================
  Files                 ?      406           
  Lines                 ?    29374           
  Branches              ?        0           
=============================================
  Hits                  ?    22121           
  Misses                ?     7253           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2504 branch 3 times, most recently from d3cc1ad to 29ca544 Compare December 6, 2024 01:54
@Huayeaaa
Copy link
Collaborator Author

Huayeaaa commented Dec 6, 2024

单测

企业微信截图_17334501092966

@Huayeaaa Huayeaaa self-assigned this Dec 11, 2024
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2504 branch from 29ca544 to 58e12a4 Compare December 13, 2024 08:41
@Huayeaaa Huayeaaa force-pushed the _V2.4.X/dev_issue#2504 branch from 58e12a4 to 1228e35 Compare December 13, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants