feat: 添加ITSM上下文配置功能 #1452
Closed
feat: 添加ITSM上下文配置功能 #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benero
reviewed
Dec 6, 2024
common/utils.py
Outdated
| receiver_type = "list" | ||
| if isinstance(receivers, str): | ||
| receiver_type = "str" | ||
| receivers = receivers.strip().split(",") | ||
|
|
||
| receivers = [i for i in receivers if i not in settings.NOTICE_IGNORE_LIST] | ||
|
|
There was a problem hiding this comment.
notice_receiver_filter(receivers)：此方法建议转到 meta 实现，主要考虑可以优化 utils 与 ContextService 的调用依赖，最好是：utils 是基础，由 ContextService 调用 utils
# Conflicts: # itsm/component/bkchat/utils.py
benero
reviewed
Dec 11, 2024
| # 接收人过滤 | ||
| receivers = notice_receiver_filter(receivers) | ||
| receivers = context_service.notice_receiver_filter(receivers) |
There was a problem hiding this comment.
建议新增【NoticeFilterService】，由此服务实现 notice_receiver_filter的功能，调用层只需要访问 NoticeFilterService 即可，不需要直接调用context_service
| return [] | ||
|
|
||
| @staticmethod | ||
| def notice_receiver_filter(receivers): |
There was a problem hiding this comment.
此实现与 ContextService 职责无关，与上个评论一样，建议独立处理
| ticket.create_moa_ticket(state_id) | ||
|
|
||
| # 如果service_id不在service_approval_blacklist中，则创建moa单据 | ||
| service_approval_blacklist = context_service.get_context_value_list( |
There was a problem hiding this comment.
同样由 notice filter service 处理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.