Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix invalid animation crash #4117

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(core): fix invalid animation crash #4117

merged 1 commit into from
Nov 7, 2024

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Nov 7, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from wwwcg November 7, 2024 08:37
@github-actions github-actions bot added dom: animation size: xs Denotes a PR that changes 0-9 lines labels Nov 7, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 7, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

wwwcg
wwwcg approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etkmao etkmao enabled auto-merge (squash) November 7, 2024 08:49
@wwwcg wwwcg disabled auto-merge November 7, 2024 09:35
@wwwcg wwwcg merged commit b9006fa into Tencent:main Nov 7, 2024
38 of 41 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Nov 7, 2024
@etkmao @wwwcg
fix(core): fix invalid animation crash (Tencent#4117)
b953a7a
wwwcg pushed a commit that referenced this pull request Nov 7, 2024
@etkmao @wwwcg
fix(core): fix invalid animation crash (#4117)
e05b2b8
Cyunong pushed a commit to Cyunong/Hippy that referenced this pull request Nov 12, 2024
@etkmao @Cyunong
fix(core): fix invalid animation crash (Tencent#4117)
20f42ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
dom: animation size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @wwwcg