Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docs): update 3.0 upgrade guidelines md #3908

Merged
merged 2 commits into from
Jun 14, 2024
Merged

refactor(docs): update 3.0 upgrade guidelines md #3908

merged 2 commits into from
Jun 14, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added doc: pages size: m Denotes a PR that changes 100-499 lines labels Jun 14, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 14, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli merged commit 30d12f9 into Tencent:main Jun 14, 2024
19 of 20 checks passed
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 14, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 14, 2024
@siguangli siguangli deleted the fix/upgrade_3.0_guidelines branch June 14, 2024 11:38
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Jun 14, 2024

⚠️ rebase-merge action execution failed, because of auto rebase and merge failed.

Please check the following details:

GraphQL: Can't disable auto-merge for this pull request. (disablePullRequestAutoMerge)

#help

@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Jun 14, 2024
siguangli added a commit to siguangli/Hippy that referenced this pull request Jul 18, 2024
@siguangli @siguangli2018
refactor(docs): update 3.0 upgrade guidelines md (Tencent#3908)
48893c2 
Co-authored-by: siguangli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed doc: pages size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @zealotchen0 @siguangli2018