Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify bundle size #3646

Closed
wants to merge 4 commits into from
Closed

minify bundle size #3646

wants to merge 4 commits into from

Conversation

yokots
Copy link
Contributor

@yokots yokots commented Nov 30, 2023

以 hippy-vue-next-demo index.android.js 为例,优化前 328KB, 优化后 302 KB。项目越大效果越明显。

优化点:

  1. 优化 hippy-vue-css-loader 生成代码体积。具体为将 HIPPY_VUE_STYLES 字符串抽取变量,减少重复。
  2. 去掉 webpack 配置中的 webpack.NamedModulesPlugin , 此 Plugin 以废弃且生成的代码中会携带源码路径信息。

优化前生成代码
origin
优化后生成代码
new

Copy link

hippy-service bot commented Nov 30, 2023

Hi, @yokots. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Nov 30, 2023
Copy link

hippy-service bot commented Nov 30, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@github-actions github-actions bot added size: m Denotes a PR that changes 100-499 lines and removed size: s Denotes a PR that changes 10-99 lines labels Dec 3, 2023
Copy link

hippy-service bot commented Mar 18, 2024

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Mar 18, 2024
Copy link

hippy-service bot commented May 18, 2024

Sorry, closing this PR because it has stalled for over 4 months.
Feel free to reopen if this PR is still relevant, or to ping the collaborator if you have any questions.

@hippy-service hippy-service bot added the stale: closed Closed due to stale label May 18, 2024
@hippy-service hippy-service bot closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js size: m Denotes a PR that changes 100-499 lines stale: closed Closed due to stale stale: 60d No interaction in the last 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants