Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/voltron modal color #3404

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Feat/voltron modal color #3404

merged 2 commits into from
Aug 17, 2023

Conversation

henryjin0511
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: voltron framework: voltron size: m Denotes a PR that changes 100-499 lines labels Jul 21, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 21, 2023

Hi, @henryjin0511. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 21, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 17, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 17, 2023 02:58
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 17, 2023
@hippy-actions hippy-actions bot merged commit c88fbb6 into Tencent:main Aug 17, 2023
31 of 32 checks passed
@henryjin0511 henryjin0511 deleted the feat/voltron-modal-color branch August 17, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@lvfen lvfen lvfen approved these changes

@skindhu skindhu Awaiting requested review from skindhu

Assignees
No one assigned
Labels
framework: voltron renderer: voltron size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryjin0511 @lvfen @zealotchen0