Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): nested rich text support vertical alignment setting #3402

Merged
merged 4 commits into from
Aug 22, 2023
Merged

feat(android): nested rich text support vertical alignment setting #3402

merged 4 commits into from
Aug 22, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Jul 21, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@iPel iPel requested a review from siguangli as a code owner July 21, 2023 07:29
@github-actions github-actions bot added renderer: native size: xl Denotes a PR that changes 1000+ lines labels Jul 21, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 21, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Aug 22, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 22, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-actions hippy-actions bot enabled auto-merge (squash) August 22, 2023 09:18
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Aug 22, 2023
@hippy-actions hippy-actions bot merged commit 22607ed into Tencent:main Aug 22, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
renderer: native size: xl Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iPel @siguangli