feat(react): remove unregisted event

Tencent · Oct 14, 2024 · 9c4891b · 9c4891b
1 parent 26a9d93
commit 9c4891b
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 26 deletions.
diff --git a/driver/js/packages/hippy-react/src/components/list-view.tsx b/driver/js/packages/hippy-react/src/components/list-view.tsx
@@ -494,20 +494,21 @@ class ListView extends React.Component<ListViewProps, ListViewState> {
       style = getFooterStyle();
     }
     if (typeof renderPullFooter === 'function') {
-      pullFooter = (
-        <PullFooter
-          // @ts-ignore
-          style={style}
-          key={'pull-footer'}
-          ref={(ref) => {
-            this.pullFooter = ref;
-          }}
-          onFooterPulling={onFooterPulling}
-          onFooterReleased={onFooterReleased}
-        >
-          { renderPullFooter() }
-        </PullFooter>
-      );
+      const footerProps: any = {
+        style,
+        key: 'pull-footer',
+        ref: (ref) => {
+          this.pullFooter = ref;
+        },
+      };
+
+      if (typeof onFooterPulling === 'function') {
+        footerProps.onFooterPulling = onFooterPulling;
+      }
+      if (typeof onFooterPulling === 'function') {
+        footerProps.onFooterReleased = onFooterReleased;
+      }
+      pullFooter = <PullFooter {...footerProps}>{renderPullFooter()}</PullFooter>;
     }
     return pullFooter;
   }

diff --git a/driver/js/packages/hippy-react/src/components/waterfall-view.tsx b/driver/js/packages/hippy-react/src/components/waterfall-view.tsx
@@ -458,18 +458,18 @@ class WaterfallView extends React.Component<WaterfallViewProps> {
   ) {
     let pullFooter: JSX.Element | null = null;
     if (typeof renderPullFooter === 'function') {
-      pullFooter = (
-        <PullFooter
-          key={'PullFooter'}
-          ref={(ref) => {
-            this.pullFooter = ref;
-          }}
-          onFooterPulling={onFooterPulling}
-          onFooterReleased={onFooterReleased}
-        >
-          { renderPullFooter() }
-        </PullFooter>
-      );
+      const footerProps: any = {
+        key: 'PullFooter',
+        ref: (ref) => {
+          this.pullFooter = ref;
+        },
+        onFooterReleased,
+      };
+
+      if (typeof onFooterPulling === 'function') {
+        footerProps.onFooterPulling = onFooterPulling;
+      }
+      pullFooter = <PullFooter {...footerProps}>{renderPullFooter()}</PullFooter>;
     }
     return pullFooter;
   }