fix(ios): nullptr exception of engine resources in rare scenarios (#4046

)
Tencent · Sep 24, 2024 · 80c5b5d · 80c5b5d
1 parent be6ae6b
commit 80c5b5d
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/framework/ios/base/executors/HippyJSExecutor.mm b/framework/ios/base/executors/HippyJSExecutor.mm
@@ -661,7 +661,11 @@ - (void)executeBlockOnJavaScriptQueue:(dispatch_block_t)block {
             return;
         }
     }
-    auto engine = [[HippyJSEnginesMapper defaultInstance] JSEngineResourceForKey:self.enginekey]->GetEngine();
+    std::shared_ptr<EngineResource> engineRsc = [[HippyJSEnginesMapper defaultInstance] JSEngineResourceForKey:self.enginekey];
+    if (!engineRsc) {
+        return;
+    }
+    auto engine = engineRsc->GetEngine();
     if (engine) {
         auto runner = engine->GetJsTaskRunner();
         if (footstone::Worker::IsTaskRunning() && runner == footstone::runner::TaskRunner::GetCurrentTaskRunner()) {
@@ -679,7 +683,11 @@ - (void)executeAsyncBlockOnJavaScriptQueue:(dispatch_block_t)block {
             return;
         }
     }
-    auto engine = [[HippyJSEnginesMapper defaultInstance] JSEngineResourceForKey:self.enginekey]->GetEngine();
+    std::shared_ptr<EngineResource> engineRsc = [[HippyJSEnginesMapper defaultInstance] JSEngineResourceForKey:self.enginekey];
+    if (!engineRsc) {
+        return;
+    }
+    auto engine = engineRsc->GetEngine();
     if (engine) {
         engine->GetJsTaskRunner()->PostTask(block);
     }