fix(android): add ControllerRegistry destroy

Tencent · Aug 12, 2024 · 482e258 · 482e258
1 parent a8f4bdf
commit 482e258
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java
@@ -178,8 +178,8 @@ public HippyCustomPropsController getCustomPropsController() {
     }
 
     public void destroy() {
-        mControllerRegistry.clear();
-        mControllerUpdateManger.clear();
+        mControllerRegistry.destroy();
+        mControllerUpdateManger.destroy();
         for (Pool<Integer, View> pool : mPreCreateViewPools.values()) {
             pool.clear();
         }

diff --git a/...erer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerRegistry.java b/...erer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerRegistry.java
@@ -49,7 +49,11 @@ public ControllerRegistry(@NonNull Renderer renderer) {
         mRendererWeakRef = new WeakReference<>(renderer);
     }
 
-    public void clear() {}
+    void destroy() {
+        mViews.clear();
+        mRootViews.clear();
+        mControllers.clear();
+    }
 
     public void addControllerHolder(String name, ControllerHolder controllerHolder) {
         mControllers.put(name, controllerHolder);

diff --git a/.../native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerUpdateManger.java b/.../native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerUpdateManger.java
@@ -83,7 +83,7 @@ public ControllerUpdateManger(@NonNull Renderer renderer) {
         mRendererWeakRef = new WeakReference<>(renderer);
     }
 
-    public void clear() {
+    void destroy() {
 
     }