fix(ios): thread race when getting uiManager

Tencent · Oct 30, 2024 · 2125b52 · 2125b52
1 parent 824bade
commit 2125b52
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/renderer/native/ios/renderer/NativeRenderManager.mm b/renderer/native/ios/renderer/NativeRenderManager.mm
@@ -258,15 +258,15 @@
             return;
         }
         HippyAssertParam(uiManager);
-        std::shared_lock<std::shared_mutex> lock(_mutex);
+        std::unique_lock<std::shared_mutex> lock(_mutex);
         _uiManagerMap[rootNode->GetId()] = uiManager;
         [uiManager registerRootView:view asRootNode:root_node];
     }
 }
 
 void NativeRenderManager::UnregisterRootView(uint32_t rootId) {
     @autoreleasepool {
-        std::shared_lock<std::shared_mutex> lock(_mutex);
+        std::unique_lock<std::shared_mutex> lock(_mutex);
         HippyUIManager *uiManager = _uiManagerMap[rootId];
         HippyAssertParam(uiManager);
         [uiManager unregisterRootViewFromTag:@(rootId)];
@@ -275,7 +275,7 @@
 }
 
 NativeRenderManager::~NativeRenderManager() {
-    std::shared_lock<std::shared_mutex> lock(_mutex);
+    std::unique_lock<std::shared_mutex> lock(_mutex);
     for (auto &pair : _uiManagerMap) {
         [pair.second invalidate];
     }