fix(jsc): fix JSCCtxValue crash after destroy engine

Tencent · Aug 8, 2023 · 188ece5 · 188ece5
1 parent 62af4ee
commit 188ece5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/driver/js/include/driver/scope.h b/driver/js/include/driver/scope.h
@@ -119,6 +119,7 @@ struct ClassTemplate {
   string_view name;
   size_t size = SIZE_OF<T>;
   std::unordered_map<void*, std::shared_ptr<T>> holder_map;
+  std::vector<std::shared_ptr<CtxValue>> holder_ctx_values;
 };
 
 class Scope : public std::enable_shared_from_this<Scope> {

diff --git a/driver/js/src/engine.cc b/driver/js/src/engine.cc
@@ -44,7 +44,12 @@ Engine::Engine()
 
 Engine::~Engine() {
   FOOTSTONE_DLOG(INFO) << "~Engine";
-  class_template_holder_map_.clear();
+  for(auto& [key, template_map] : class_template_holder_map_) {
+    auto animation_template = std::any_cast<std::shared_ptr<ClassTemplate<CubicBezierAnimation>>>(template_map["Animation"]);
+    animation_template->holder_ctx_values.clear();
+    auto animation_set_template = std::any_cast<std::shared_ptr<ClassTemplate<AnimationSet>>>(template_map["AnimationSet"]);
+    animation_set_template->holder_ctx_values.clear();
+  }
 }
 
 void Engine::AsyncInitialize(std::shared_ptr<TaskRunner> js,

diff --git a/driver/js/src/modules/animation_module.cc b/driver/js/src/modules/animation_module.cc
@@ -537,16 +537,22 @@ RegisterAnimation(const std::weak_ptr<Scope>& weak_scope) {
       exception = context->CreateException("cb is not a function");
       return nullptr;
     }
-    auto cb = [weak_scope, func] { // run in js thread
+    std::weak_ptr<CtxValue> weak_func = func;
+    auto cb = [weak_scope, weak_func] { // run in js thread
       auto scope = weak_scope.lock();
       if (!scope) {
         return;
       }
       auto context = scope->GetContext();
-      context->CallFunction(func, context->GetGlobalObject(), 0, nullptr);
+      auto func = weak_func.lock();
+      if (func) {
+        context->CallFunction(func, context->GetGlobalObject(), 0, nullptr);
+      }
     };
     animation->AddEventListener(StringViewUtils::ToStdString(StringViewUtils::ConvertEncoding(
         event_name, string_view::Encoding::Utf8).utf8_value()), std::move(cb));
+    auto class_template_ptr = std::any_cast<std::shared_ptr<ClassTemplate<CubicBezierAnimation>>>(scope->GetClassTemplate("Animation"));
+    class_template_ptr->holder_ctx_values.emplace_back(func);
     return nullptr;
   };
   class_template.functions.emplace_back(std::move(add_event_listener_func_def));
@@ -809,16 +815,22 @@ RegisterAnimationSet(const std::weak_ptr<Scope>& weak_scope) {
       exception = context->CreateException("cb is not a function");
       return nullptr;
     }
-    auto cb = [weak_scope, func] {
+    std::weak_ptr<CtxValue> weak_func = func;
+    auto cb = [weak_scope, weak_func] {
       auto scope = weak_scope.lock();
       if (!scope) {
         return;
       }
       auto context = scope->GetContext();
-      context->CallFunction(func, context->GetGlobalObject(), 0, nullptr);
+      auto func = weak_func.lock();
+      if (func) {
+        context->CallFunction(func, context->GetGlobalObject(), 0, nullptr);
+      }
     };
     animation_set->AddEventListener(StringViewUtils::ToStdString(StringViewUtils::ConvertEncoding(
         event_name, string_view::Encoding::Utf8).utf8_value()), std::move(cb));
+    auto class_template_ptr = std::any_cast<std::shared_ptr<ClassTemplate<AnimationSet>>>(scope->GetClassTemplate("AnimationSet"));
+    class_template_ptr->holder_ctx_values.emplace_back(func);
     return nullptr;
   };
   def.functions.emplace_back(std::move(add_event_listener_func_def));