Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Project to TypeScript #226

Open
wants to merge 21 commits into
base: v5
Choose a base branch
from

Conversation

RebeccaStevens
Copy link

No description provided.

@RebeccaStevens RebeccaStevens force-pushed the typescript branch 6 times, most recently from 68e83a8 to fb69b46 Compare January 23, 2021 10:53
@RebeccaStevens RebeccaStevens marked this pull request as ready for review January 23, 2021 13:04
export function getFullOptions<O extends Options>(inputOptions?: O) {
const overrides = inputOptions === undefined
? undefined
: Object.fromEntries(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TehShrike
Object.fromEntries requires node 12+. If we want to support node 10 (lts ends 2021-04-30) we'll have to either polyfill this or do it in another way (which shouldn't be too big a deal).

@RebeccaStevens RebeccaStevens mentioned this pull request Jan 23, 2021
@frolovdev
Copy link

@RebeccaStevens Hey I think you did a great job, what about creating a separate package with implementation from the current pr? I guess it brings much more value than wait until the maintainer decides to accept your work. I'll be your first user :dd

@frolovdev
Copy link

@RebeccaStevens Hey I think you did a great job, what about creating a separate package with implementation from the current pr? I guess it brings much more value than wait until the maintainer decides to accept your work. I'll be your first user :dd

We want to use your implementation in Osome.com, and I faced the next dilemma to copy-paste and go or use your package and maintain it together. Wait for your thoughts.

@RebeccaStevens
Copy link
Author

RebeccaStevens commented Aug 20, 2021

I'd be happy to. I've actually been thinking about doing this already but haven't got round to it.
Any suggestions for a name of the package? deepmerge2 is already taken 😛. I might just release it under my user scope @rebeccastevens/deepmerge.

I've also got some ideas on improving the functionality. I'd probably also end up dropping native support for es5.

@frolovdev
Copy link

frolovdev commented Aug 21, 2021

@RebeccaStevens I guess the name is doesn't matter in terms of the end user. But the one way to think about it is how to get more SEO traffic :d

So it can be

ts-merge-deep
type-deepmerge
typed-deepmerge

So anyway, wait for your next steps 💯

@RebeccaStevens
Copy link
Author

RebeccaStevens commented Aug 25, 2021

@frolovdev I've just release my own take on deep merge.

https://www.npmjs.com/package/deepmerge-ts

Currently the merging functionality can't be customized but that's what I'm going to be working on next. - Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants