Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estefanny's weather app PR #428

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

FannyEste
Copy link

@JennieDalgren JennieDalgren self-assigned this Oct 4, 2024
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this project!

You've nailed most of the functionality that was required this week. However, it seems like the min and max temperatures are showing the same values.
Also I'm wondering what this time (17:40) indicates?
image

HTML and CSS

  • Good use of semantic HTML elements and attributes.
  • Consistent use of font families and sizes.
  • Proper use of flexbox for layout management.
  • Clear separation of styles for different components (search icon, current weather, forecast).

JavaScript

  • Good structure and understandable cide

  • Proper error handling with try/catch blocks.

  • DRY Principle: Refactor to avoid repetition in API URLs.

    const baseUrl = "https://api.openweathermap.org/data/2.5/";
    const city = "Stockholm,Sweden";
    const units = "metric";
    const apiUrl = `${baseUrl}weather?q=${city}&units=${units}&APPID=${apiKey}`;
    const forecastApiUrl = `${baseUrl}forecast?q=${city}&units=${units}&APPID=${apiKey}`;

Things to fix:

  • Make sure to be consistent, use single or double quotes throughout the script.
  • Check the min max temp data so it shows the correct data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants