project weather- swiss #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://magical-figolla-dee05d.netlify.app/ Sorry for the delay. |
JennieDalgren
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Good job!
You have met all requirements for this project.
The html and css is good structured, however I would love to have seen the weekdays coming from the javascript rather then being hardcoded in the html file. This is not something you have to change, just a small comment.
Good structure of the js file too and you functions, naming functionality etc. Try to stick to english for the comments so it is readable for us too :)
Good job!
|
Thank you for your feedback. I'll incorporate the days in my javascript next time. It seems more easier to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
Add your Netlify link here.
PS. Don't forget to add it in your readme as well.