Weather App #415
Open
Weather App #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- day/night modus
HIPPIEKICK
previously requested changes
Oct 3, 2024
There was a problem hiding this comment.
HTML/CSS
- Great that you're using semantic elements such as header and main. Consider also utilizing section and article so you don't overuse divs
- Overall, your CSS is clear and cleanly organized. The use of flexbox for layout management is great. Just have a look at how your app looks like in 320px width (the content doesn't fit)
JavaScript
- Nice to see that you're using async/await and try/catch 🥳
- Remember to remove console.logs from productions (the ones that are not logging errors at least)
- Nice job implementing the search function and converting the times to the different time zones ⭐
All in all, a lot of nice little features 🌞 🌚 Keep up the good work!
Changes Requested
- Make sure it's responsive on 320px as well (iPhone 5/SE)
|
Thank you!!! It should be fixed now! |
|
done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gittes-weather-app.netlify.app/