-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project movies! #319
Open
Amanda-Sjstrm
wants to merge
13
commits into
Technigo:master
Choose a base branch
from
Amanda-Sjstrm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Project movies! #319
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
862c500
setting everything up
Amanda-Sjstrm fcf33b4
added components and fetched API
Amanda-Sjstrm 1a44f12
added stuff to details component
Amanda-Sjstrm 97064a6
css update
Amanda-Sjstrm f4130b3
added styling to list component
Amanda-Sjstrm ca0299e
-
Amanda-Sjstrm 5f5aea0
Update README.md
Amanda-Sjstrm daeacd1
Update README.md
Amanda-Sjstrm 5f3343b
Update netlify.toml
Amanda-Sjstrm 1e0fee5
Merge branch 'master' of https://github.com/Amanda-Sjstrm/project-movies
Amanda-Sjstrm 8547744
added imdb button
Amanda-Sjstrm a951241
Hiding the imdb button...
Amanda-Sjstrm 4208670
Update index.css
Amanda-Sjstrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"editor.defaultFormatter": "rvest.vs-code-prettier-eslint", | ||
"editor.formatOnPaste": false, // required | ||
"editor.formatOnType": false, // required | ||
"editor.formatOnSave": true, // optional | ||
"editor.formatOnSaveMode": "file", // required to format on save | ||
"files.autoSave": "onFocusChange", // optional but recommended | ||
"vs-code-prettier-eslint.prettierLast": false // set as "true" to run 'prettier' last not first | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
# Project Movies | ||
|
||
Replace this readme with your own information about your project. | ||
## What you will learn | ||
|
||
Start by briefly describing the assignment in a sentence or two. Keep it short and to the point. | ||
✓ Pair-programming | ||
|
||
## The problem | ||
✓ How to build multi-page applications using React Router. | ||
|
||
Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next? | ||
✓ How to pass information such as product ids, or blog post titles in the URL and pick this up in React router to load dynamic content. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'd suggest writing more about the difficulties of the project, even as keywords, so you can remember it later on when you are going through your project (for example during the recruitment processes). |
||
|
||
✓ Practice using APIs in React - combining `useState` with `useEffect` | ||
|
||
## View it live | ||
|
||
Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about. | ||
https://glistening-tiramisu-f31c45.netlify.app/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to read more about the topic for the project (movies) + your information about pair programming :)