-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guess Who? - Dog edition by Anna Robertsson #345
base: main
Are you sure you want to change the base?
Conversation
…on, added counter and sound effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Anna! From what I can see the code works and fulfills requirements (and then some!). I enjoyed playing the games with the dogs you've added!
} | ||
|
||
// It'll filter the characters array and redraw the game board. | ||
// Filter the characters array and redraw the game board by determining what is the category, and if it's to keep or remove based on the keep variable | ||
const filterCharacters = (keep) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on changing the game to dogs! Do you think line 435-512 might be good to comment a bit more, just short ones to make eg. next developer looking at this find things a bit easier? Like:
// Fur color
// Ears
etc.?
} | ||
|
||
// Invokes a function to redraw the board with the remaining dogs | ||
generateBoard(charactersInPlay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we've been doing the same project I compared to mine, I have just used the
generateBoard()
does that work for your code?
I started by looking through the material for the week and then started to code. I think the instructions of the project and the starter code were a good help to get started. I used a bit of Stack Overflow but mainly chatGPT when I got stuck. I also double checked with chatGPT if my code looked good. I had great help from my team mates through our discussions.
If I had more time I would rename the characters in the code when they are called 'person' to 'dogs' because it would make more sense since I switched to a dog theme. However 'person' is used in variables and values and therefore I didn't change it now since there was a risk something might not work in the code and I then wouldn't have time to fix it.
Please visit:
https://project-guess-who-anna-robertsson.netlify.app