-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Project: OMC Book Club - Ji, Maja, Viktoria #50
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: jyy009 <[email protected]>
refactor server.js
Co-authored-by: Maja Schouenke <[email protected]>
Co-authored-by: Maja Schouenke <[email protected]>
create landing page
update like icon for wishlist
updated book info
style margins
finish styling
add button hover bg
create readme info
move readme to correct file
add loading animation to profile and sign up page
debug navbar popup
Co-authored-by: jyy009 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Ji, Maja and Viktoria, congratulations for getting to the finish line and complete your final project! 🎓
I am so impressed you could deliver an app in only 3 weeks, you should be proud of yourself and what you accomplished! I would like to summarise in some points what I think about your app:
- Very well-structured and formatted code
- Polished final app, with smooth flow and good UX (info texts, animations, easy to navigate)
- Clean UI
- Robust and concise database data structure
- Nailed accessibility
- Nailed responsiveness
- Well documented project in your README
Are the founders of your projects aliases for your names or why not using your real names? And why not adding a link to IG or LinkedIn? I understand there is no bookclub social media accounts, but as general rule, hide anything from the UI if it doesn't have a functionality or it's work in progress.
You passed this assignment and I encourage you to continue to develop, expand and improve it if you wish in the future ⭐ Well done, cheers 🥂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.json files are not components, move this file into to src
folder, there you can create a folder called data
if you wish to store the data files 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the other .json file :)
Netlify link
Frontend: https://main--omc-book-club.netlify.app/
Backend: https://project-final-rvhj.onrender.com
Collaborators
[jyy009, schouenkes]