Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Solar System Travel Guide - Alex, Axel & Lovisa #49

Open
wants to merge 208 commits into
base: main
Choose a base branch
from

Conversation

Lovisaaberg
Copy link

@Lovisaaberg Lovisaaberg commented Jun 18, 2024

Alexandra Franzén
[Xikitita]

Axel Hellners
[AHPIXI]

Lovisa Åberg
[Lovisaaberg]

View it live

Frontend: https://thesolarsystemtravelguide.netlify.app
Backend: https://project-final-45vw.onrender.com

Xikitita and others added 30 commits May 27, 2024 17:42
Created schema/model for live feed
changed outcommented lines in app.jsx
Created route handlers for space feed
fetch function in PlanetCards-component
Xikitita and others added 26 commits June 12, 2024 14:13

* attempt to solve cors issue
* added default loading to components
Fixed responsivness on landing page and small other changes
Co-authored-by: AHPIXI <[email protected]>
Co-authored-by: Lovisa Åberg <[email protected]>
Added some features for accessibility and small changes on margins
Animation added for scrolling down
Added form to converter for tabing
Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Alex, Axel & Lovisa, big congratulations for completing the bootcamp and delivering such a great app! 🎓

I am so impressed with your work but most of all amused! I've had so much fun using your app, and first of all, I was today years old when I learned that Tellus is a Latin word for” Earth”! So extra points to you for educating me 😆 💯

In this final project, we asked you to plan your bigger project work, further deepen your knowledge in web development and finally explore new technologies! Let me tell you, you surely succeeded in all these aspects!

The app is absolutely gorgeous, from the design to the flow, nothing was left unplanned. The code is really well structured and written, clean formatted and readable, the backend is robust and structured in modules to improve scalability and readability. From the animations to the aspects like responsiveness and accessibility, the app represents a good planning work and organised execution, in only 3 weeks this is truly admirable and professional work. You should be PROUD!

Here's some aspects that can be taken into consideration for further improvements:

  • Deploy routes on Netlify adding the netlify.toml file (required)

Tips for improvements:

  • unit for distance - normally Miles + Fahrenheit / Km + Celsius (for future versions would be nice to add a unit selector)
  • having an interactive map of our solar system would be so cool!

Again, massive congrats for your efforts, you proved you’re ready to be graduated developers now ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants