Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance measurer toggle button and fix copy coordinates bug #4

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

Zefire85
Copy link
Contributor

@Zefire85 Zefire85 commented Sep 6, 2024

Added a toggle button for the ruler.
Fixed a compatibility bug with the 'copy-coordinates' script.

@TechnicJelle TechnicJelle linked an issue Sep 6, 2024 that may be closed by this pull request
@TechnicJelle
Copy link
Owner

TechnicJelle commented Sep 6, 2024

Thank you for your contribution!
I will test this out soon(ish, I hope...), and merge it if I have no further remarks!

@Michael-1001
Copy link

I tried your code out but:

  1. I couldn't see the toggle (well, a marker does appear named bm-popup-set but it's untoggleable)
  2. But the distance does appear in web console + in that bm-popup-set marker)

@Zefire85
Copy link
Contributor Author

The bm-popup-set marker is not my own, the 'Distance Measurer' addon alone also makes it appear. I only reworked the code for the moment.

If the toggle does not appear, it is possibly due to the fact that it is not positioned in the same place for everyone. When I coded the button, I gave it a position (modifiable in the code) but friends of mine pointed out to me that depending on the size of the screen, the browser or the zoom applied to the same browser, the button was not in the same place, or even behind the BlueMap buttons. Which can be very annoying since it is the one that allows you to enable and disable the distance measurement.

Zefire85 and others added 2 commits November 25, 2024 00:20
Added a toggle button for the ruler.
Fixed a compatibility bug with the 'copy-coordinates' script.
@Chicken Chicken merged commit 4e4c133 into TechnicJelle:main Nov 24, 2024
@Chicken Chicken changed the title Bug fix and toggle button Distance measurer toggle button and fix copy coordinates bug Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Distance Measurer and Copy Coordinates web module together.
4 participants