Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer.json #32

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add composer.json #32

merged 1 commit into from
Aug 21, 2024

Conversation

mlutfy
Copy link
Contributor

@mlutfy mlutfy commented Aug 20, 2024

Makes it easier to handle code updates when using composer.

@twomice
Copy link
Collaborator

twomice commented Aug 20, 2024

@mlutfy I like the idea here. Quick question: is there a common standard naming convention for properties like name and type on civicrm extensions? (Revealing my composer ignorance here.)

@mlutfy
Copy link
Contributor Author

mlutfy commented Aug 20, 2024

@twomice The convention is:

  • name civicrm/short-name
  • description: similar to what's in the info.xml

I defer to the folks of iXiam, who have been encouraging this convention: https://lab.civicrm.org/extensions/summernote/-/blob/1.x/composer.json

civix discussions: totten/civix#267

@twomice twomice merged commit 669a251 into TechToThePeople:master Aug 21, 2024
@twomice
Copy link
Collaborator

twomice commented Aug 21, 2024

Merged -- thanks @mlutfy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants