Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namedExport support #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ module.exports = {
| **[`verifyOnly`](#verifyOnly)** | `{Boolean}` | Validate generated `*.d.ts` files and fail if an update is needed (useful in CI) |
| **[`disableLocalsExport`](#disableLocalsExport)** | `{Boolean}` | Disable the use of locals export. |
| **[`prettierConfigFile`](#prettierConfigFile)** | `{String}` | Path to prettier config file |
| **[`namedExport`](#namedExport)** | `{Boolean}` | Interpret `namedExport` of css-loader. |

### `banner`

Expand Down Expand Up @@ -217,6 +218,37 @@ module.exports = {
};
```

### `namedExport`

Interpret `namedExport` of css-loader.

```js
module.exports = {
module: {
rules: [
{
test: /\.css$/i,
use: [
{
loader: "@teamsupercell/typings-for-css-modules-loader",
options: {
namedExport: true,
}
},
{
loader: "css-loader",
options: {
modules: {
namedExport: true,
}
}
}
]
}
]
}
};
```


## Example
Expand Down
29 changes: 21 additions & 8 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
const {
filenameToPascalCase,
filenameToTypingsFilename,
getCssModuleKeys,
getCssModuleKeysForLocalExport,
getCssModuleKeysForNamedExport,
generateGenericExportInterface,
} = require("./utils");
const persist = require("./persist");
Expand Down Expand Up @@ -40,6 +41,10 @@ const schema = {
description:
"Path to prettier config file",
type: "string",
},
namedExport: {
description: "Interpret `namedExport` of css-loader",
type: "boolean",
}
},
additionalProperties: false,
Expand All @@ -61,13 +66,21 @@ module.exports = function (content, ...args) {
this.cacheable();
}

// let's only check `exports.locals` for keys to avoid getting keys from the sourcemap when it's enabled
// if we cannot find locals, then the module only contains global styles
const indexOfLocals = content.indexOf(".locals");
const cssModuleKeys =
indexOfLocals === -1
? []
: getCssModuleKeys(content.substring(indexOfLocals));
let cssModuleKeys = [];

if (options.namedExport) {
const indexOfExports = content.indexOf("// Exports");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (indexOfExports !== -1) {
cssModuleKeys = getCssModuleKeysForNamedExport(content.substring(indexOfExports))
}
} else {
// let's only check `exports.locals` for keys to avoid getting keys from the sourcemap when it's enabled
// if we cannot find locals, then the module only contains global styles
const indexOfLocals = content.indexOf(".locals");
if (indexOfLocals !== -1) {
cssModuleKeys = getCssModuleKeysForLocalExport(content.substring(indexOfLocals));
}
}

/** @type {any} */
const callback = this.async();
Expand Down
16 changes: 11 additions & 5 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ const path = require("path");
const camelCase = require("camelcase");

/**
* @param {string} content
* @returns {string[]}
* @param {RegExp} keyRegex
* @returns {(content: string) => string[]}
*/
const getCssModuleKeys = (content) => {
const keyRegex = /"([\w-]+)":/g;
const getCssModuleKeys = (keyRegex) => (content) => {
let match;
const cssModuleKeys = [];

Expand All @@ -19,6 +18,12 @@ const getCssModuleKeys = (content) => {
return cssModuleKeys;
};

/** @type {(content: string) => string[]} */
const getCssModuleKeysForLocalExport = getCssModuleKeys(/"([\w-]+)":/g);

/** @type {(content: string) => string[]} */
const getCssModuleKeysForNamedExport = getCssModuleKeys(/export const ([\w-]+) =/g);

/**
* @param {string} filename
*/
Expand Down Expand Up @@ -79,7 +84,8 @@ export = ${moduleName};`;
};

module.exports = {
getCssModuleKeys,
getCssModuleKeysForLocalExport,
getCssModuleKeysForNamedExport,
filenameToPascalCase,
filenameToTypingsFilename,
generateGenericExportInterface,
Expand Down
18 changes: 18 additions & 0 deletions test/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -283,3 +283,21 @@ declare const ExampleCssModule: ExampleCssNamespace.IExampleCss & {
export = ExampleCssModule;
"
`;

exports[`css-loader@latest with named export 1`] = `
"declare namespace ExampleCssNamespace {
export interface IExampleCss {
barBaz: string;
composed: string;
foo: string;
}
}

declare const ExampleCssModule: ExampleCssNamespace.IExampleCss & {
/** WARNING: Only available when \`css-loader\` is used without \`style-loader\` or \`mini-css-extract-plugin\` */
locals: ExampleCssNamespace.IExampleCss;
};

export = ExampleCssModule;
"
`;
17 changes: 17 additions & 0 deletions test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,23 @@ describe("css-loader@latest", () => {
const verifyMock = jest.requireMock("../src/verify");
expect(verifyMock).toBeCalledTimes(1);
});

it("with named export", async () => {
await runTest({
options: {
namedExport: true,
},
cssLoaderOptions: {
modules: {
namedExport: true,
}
}
});

const persistMock = jest.requireMock("../src/persist");
expect(persistMock).toBeCalledTimes(1);
expect(persistMock.mock.calls[0][1]).toMatchSnapshot();
});
});

describe("css-loader@3", () => {
Expand Down
51 changes: 40 additions & 11 deletions test/utils.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// @ts-check
const { filenameToPascalCase, getCssModuleKeys } = require("../src/utils");
const {
filenameToPascalCase,
getCssModuleKeysForLocalExport,
getCssModuleKeysForNamedExport,
} = require("../src/utils");

describe("filenameToPascalCase", () => {
it("camelCase", () => {
Expand All @@ -23,22 +27,38 @@ describe("filenameToPascalCase", () => {
});
});

describe("getCssModuleKeys", () => {
describe.each`
description | fn
${"localExport"} | ${getCssModuleKeysForLocalExport}
${"namedExport"} | ${getCssModuleKeysForNamedExport}
`("getCssModuleKeys / common / $description", ({ fn }) => {
it("empty CSS module", () => {
const content = `
exports = module.exports = require("../node_modules/css-loader/dist/runtime/api.js")(false);
// Module
exports.push([module.id, "", ""]);
`;
const actual = getCssModuleKeys(content);
const actual = fn(content);
expect(actual).toEqual([]);
});

it("CSS module with :root pseudo-class only", () => {
const content = `
exports = module.exports = require("../node_modules/css-loader/dist/runtime/api.js")(false);
// Module
exports.push([module.id, ":root {\n --background: green; }\n", ""]);
`;
const actual = fn(content);
expect(actual).toEqual([]);
});
});

describe("getCssModuleKeysForLocalExport", () => {
it("CSS module with one class", () => {
const content = `exports.locals = {
"test": "test"
};`;
const actual = getCssModuleKeys(content);
const actual = getCssModuleKeysForLocalExport(content);
expect(actual).toEqual(["test"]);
});

Expand All @@ -47,17 +67,26 @@ describe("getCssModuleKeys", () => {
"test1": "test1",
"test2": "test2"
};`;
const actual = getCssModuleKeys(content);
const actual = getCssModuleKeysForLocalExport(content);
expect(actual).toEqual(["test1", "test2"]);
});
});

it("CSS module with :root pseudo-class only", () => {
describe("getCssModuleKeysForNamedExport", () => {
it("CSS module with one class", () => {
const content = `
exports = module.exports = require("../node_modules/css-loader/dist/runtime/api.js")(false);
// Module
exports.push([module.id, ":root {\n --background: green; }\n", ""]);
export const test = "test";
`;
const actual = getCssModuleKeys(content);
expect(actual).toEqual([]);
const actual = getCssModuleKeysForNamedExport(content);
expect(actual).toEqual(["test"]);
});

it("CSS module with multiple classes", () => {
const content = `
export const test1 = "test1";
export const test2 = "test2";
`;
const actual = getCssModuleKeysForNamedExport(content);
expect(actual).toEqual(["test1", "test2"]);
});
});