Enable Rumble FF Autofire #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FF mode if Autofire is enabled
SeongGino
reviewed
Jul 4, 2024
| } else if(rumbleHappened) { // If rumble has happened, | ||
| rumbleHappened = false; // well we're clear now that we've stopped holding. | ||
|
|
||
| // If Rumble FF is enabled and Autofire is enabled, the motor needs to be disabled when the trigger is released. Otherwiseallow RumbleActivation to deal with the activation timer |
There was a problem hiding this comment.
"Otherwiseallow?" I think your typing was on autofire for a bit there.
SeongGino
reviewed
Jul 4, 2024
| digitalWrite(SamcoPreferences::pins.oRumble, LOW); // Make sure the rumble is OFF. | ||
| rumbleHappening = false; // This rumble command is done now. | ||
| rumbleHappened = true; // And just to make sure, to prevent holding == repeat rumble commands. | ||
| if(!SamcoPreferences::toggles.autofireActive) { // We only want to use the rumble timer is Autofire is not active. Otherwise, keep it going |
There was a problem hiding this comment.
I think you meant "We only want to use the rumble timer if Autofire is not active. ..."
|
I should also ask, as this was part of the app side PR to go along with this:
How so? It doesn't seem as if these changes even touches solenoid values for rumble FF. |
|
My bad - I wrote that when I first thought of how it would work (option 1) before deciding to go with another method (option 2) |
|
Closing in favor of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rumble works exactly as before except for the addition of a new Rumble FF Autofire feature.
If Autofire is disabled, nothing changes. If you are pointing at the screen, a single pulse is sent to the rumble motor on trigger pull that lasts for a specified duration at a specified strength
If Autofire is enabled however, and you are pointing on screen, the motor will activate and the specified strength until you release the trigger.
This feature was added to make games that use Autofire mode much more enjoyable when Rumble FF is used (if you don't have a solenoid, or you simply want quieter feedback as not to annoy those around you)