feat: improvements to oxygen and suffocation #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the oxygen overlay
…ask and oxygen gear
… sprite looks like a battery and doesn't match the new oxygen tank textures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #393
Changed rendering order of dark and light oxygen overlays so that the dark overlay is on top as this simplifies the calculations and fixes the visual problems.
Also swapped oxygen tanks which were displayed the wrong way round in the oxygen overlay.
Additionally display the oxygen overlay whenever the player is wearing both an oxygen mask and oxygen gear since the oxygen setup works in underwater too and not just space.
Fixed #390
The way that suffocation damage was applied has been changed to no longer use the same code as drowning in water. This resolves several issues including a more appropriate death message and no bubble particles when taking suffocation (drowning) damage. The "no_impact" tag has been added for suffocation damage so that the player is not sent flying around on the moon when they run out of oxygen.