-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field Length Increased #506
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
@@ -46,14 +46,14 @@ public abstract class BasePoseSubsystem extends BaseSubsystem implements DataFra | |||
protected BooleanProperty rioRotated; | |||
protected boolean firstUpdate = true; | |||
protected double lastSetHeadingTime; | |||
public static double fieldXMidpointInMeters = 8.2705; | |||
public static double fieldXMidpointInMeters = 8.7785; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ while we're here, consider turning this into a Distance value of Meters.of instead
public static double fieldXMidpointInMeters = 8.7785; | |
public static Distance fieldXMidpoint = Meters.of(8.7785); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add a comment about what years field this is for? Maybe have a list of past lengths in case someone was running 2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did we get this new value from? The field is relatively evergreen, so this one surprises me a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Game Manual specified the field length as approximately 26ft. 5in. by 57ft. 6(7/8)in. I took the length and converted it to meters then halved it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify this using AdvantageScope? If you drive the robot to 8.7785, is it exactly in the middle of the field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I verified it
Why are we doing this?
Fixes Pose2d conversions from Blue Alliance to Red Alliance
Whats changing?
BasePoseSubsystem fieldXMidpointInMeters
Questions/notes for reviewers
How this was tested