Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swerve simple trajectory update #485

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

Rongrrz
Copy link
Contributor

@Rongrrz Rongrrz commented Nov 9, 2024

Why are we doing this?

Option to plug in Kinematic values for the SwerveSimpleTrajectory command

Whats changing?

Questions/notes for reviewers

  • Needs testing on robot
  • Some stuff could use renaming/better names
  • Based on testing, it seems like the robot internally has some speed limits so it can't just go crazy in the simulator
  • Not too sure about the units...

How this was tested

  • unit tests added
  • tested on robot

VIDEO!!!

BestVideoEver.mp4

Rongrrz added 14 commits October 5, 2024 13:46
Hopefully this covers all the possibilities...
MM/DD/YY
…am488/SeriouslyCommonLib into SwerveSimpleTrajectory-update
…b.com/Team488/SeriouslyCommonLib into SwerveSimpleTrajectory-update"

This reverts commit ea9d1a0, reversing
changes made to 574d595.
Changed so that instead of cruising in deceleration, will accelerate to minimize time as well.
@Rongrrz Rongrrz marked this pull request as ready for review November 27, 2024 18:52
@Rongrrz Rongrrz requested a review from a team as a code owner November 27, 2024 18:52
GlobalKinematics not working, look into it!
@Rongrrz Rongrrz removed the dont merge label Jan 7, 2025
Clean up
More concise variables names and cleaned comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant