Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose/community] 커뮤니티 하단 댓들창 구현 #74

Merged
merged 6 commits into from
May 7, 2024

Conversation

yonghanJu
Copy link
Contributor

😎 작업 내용

  • 커뮤니티 하단 댓들창 구현

🥳 동작 화면

gif

🤯 이슈 번호

  • 이슈 없음

🥲 비고

  • 비고 없음

@yonghanJu yonghanJu changed the title Compose/community [Compose/community] 커뮤니티 하단 댓들창 구현 Apr 18, 2024
@yonghanJu yonghanJu self-assigned this Apr 18, 2024
Copy link
Member

@soopeach soopeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!
너무 완벽하네요

postRepo.getComments(post.id).onSuccess {
comments = it
comments = it.reversed()
Log.d("ju0828", it.toString())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋ 궁금한게 있는데, 다른 프로젝트에서도 그 분 로그를 보면 로그 ID를 본인 아이디로 하시더라고요??
혹시 자동으로 그렇게 해주는 기능이 있는 건가요? 아니면 그냥 편해서 이렇게 수동으로 하시는 건가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 수동으로 했습니다... ㅎㅎㅎ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 수동으로 하곤 하는데 내가 작업 중인 여러 파일에 timber 찍은거 한번에 확인하기 편해서 제 이름으로 해요~

verticalAlignment = Alignment.CenterVertically,
) {
listOf(
"❤\uFE0F",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 하트는 아예 이렇게도 들어가나보네요??

Comment on lines 361 to 366
fun CommentScreenPreview() {
val repo: PostRepository = get()
WalkieTheme {
CommentScreen(post = Post.DUMMY)
CommentScreen(post = Post.DUMMY, postRepo = repo)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

용한님은 프리뷰 기능 잘 사용하시나요???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 저는 잘 사용하고 있습니다.
IDE 오른쪽에 보이는 프리뷰말고 휴대폰이나 에뮬레이터에 preview 만 launch해서 사용하는 경우가 많이 있는 것 같아요

@yonghanJu yonghanJu merged commit 0ff9189 into compose/develop May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants