Fix [#82] 1.1.0버전 최종 QA 반영 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinUng41
approved these changes
Nov 29, 2024
Comment on lines
+10
to
+14
| extension Array { | ||
| subscript(safe index: Int) -> Element? { | ||
| return indices.contains(index) ? self[index] : nil | ||
| } | ||
| } |
There was a problem hiding this comment.
오, 이렇게 익스텐션으로 구현하신 이유가 궁금하네요.
Comment on lines
+94
to
+103
| let currentComponents = currentVersion.split(separator: ".").map { Int($0) ?? 0 } | ||
| let marketingComponents = marketingVersion.split(separator: ".").map { Int($0) ?? 0 } | ||
|
|
||
| let currentMajor = currentComponents[safe: 0] ?? 0 | ||
| let currentMinor = currentComponents[safe: 1] ?? 0 | ||
| let currentPatch = currentComponents[safe: 2] ?? 0 | ||
|
|
||
| let marketingMajor = marketingComponents[safe: 0] ?? 0 | ||
| let marketingMinor = marketingComponents[safe: 1] ?? 0 | ||
| let marketingPatch = marketingComponents[safe: 2] ?? 0 |
There was a problem hiding this comment.
nil값을 대체하기 위해 많은 부분에서 기본값으로 0이 선언되어 있는데요.
이렇게 되면, nil일 때의 추적이 어렵고 기본값에 대한 의도치 않는 문제가 발생할 수 있다는 단점이 있을 것 같습니다.
이를 옵셔널 바인딩으로 처리하는 것은 어떨까요?
Comment on lines
+56
to
+62
| for (current, appStore) in zip(currentComponents, appStoreComponents) { | ||
| if current < appStore { | ||
| return true | ||
| } else if current > appStore { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
오 zip을 사용하셨군요! 👍
반복문 안에서 두 값이 같을 때의 처리는 없는데, 상관없는 부분일까요?
|
|
||
| if replyData.count % 15 == 0 && viewModel.cursor != lastCommentID && (scrollView.contentOffset.y + scrollView.frame.size.height) >= (scrollView.contentSize.height) { | ||
| if unFlattenDatas.count % 10 == 0 && viewModel.cursor != lastCommentID && (scrollView.contentOffset.y + scrollView.frame.size.height) >= (scrollView.contentSize.height) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻 PULL REQUEST
🛠️ PR POINT
💡 참고사항
📸 스크린샷
📟 관련 이슈