Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] @Transactional 어노테이션 재배치 #73

Merged
merged 1 commit into from
Jun 22, 2024
Merged

[REFACTOR] @Transactional 어노테이션 재배치 #73

merged 1 commit into from
Jun 22, 2024

Conversation

ChaeAg
Copy link
Member

@ChaeAg ChaeAg commented Jun 17, 2024

Related Issue

Key Changes

이전에 정한 @transactional 어노테이션 위치 컨벤션을 현재 개발 완료된 코드에 반영했습니다.

  • Service 레이어에 기본 어노테이션을 작성하고, 조회용 메서드에 따로 (readOnly = true) 설정을 진행했습니다!

To Reviewers

X

References

X

rinarina0429
rinarina0429 reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AvatarService, BlockService도 수정할 부분이 있는 것 같은데 누락된 것 같습니다! 여기저기 수정 수고하셨습니다~

src/main/java/org/websoso/WSSServer/service/NoticeService.java Show resolved Hide resolved
@ChaeAg ChaeAg requested a review from rinarina0429 June 17, 2024 17:04
rinarina0429
rinarina0429 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~

Kim-TaeUk
Kim-TaeUk approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Kim-TaeUk Kim-TaeUk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다 귀찮을텐데! 👍

@ChaeAg ChaeAg merged commit 12301a0 into dev Jun 22, 2024
2 checks passed
@ChaeAg ChaeAg deleted the refactor/#61 branch June 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kim-TaeUk Kim-TaeUk Kim-TaeUk approved these changes

@rinarina0429 rinarina0429 rinarina0429 approved these changes

Assignees

@ChaeAg ChaeAg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] @Transactional 어노테이션 관련 컨벤션 반영
3 participants
@ChaeAg @Kim-TaeUk @rinarina0429