[HOTFIX] NovelStatisticsService에서 NovelService 참조 로직 제거 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinarina0429
approved these changes
Jun 10, 2024
Kim-TaeUk
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
NovelStatisticsService와NovelService클래스 간 서로를 참조하고 있어, 발생하는 순환참조를 제거했습니다.제거 방법은
NovelStatisticsService클래스에서NovelService참조를 제거하고,FeedService에서NovelStatisticsService에게Novel엔티티 자체를 파라미터로 전달하는 식으로 로직을 변경해,순환참조를 없앴습니다.
To Reviewers
X
References
X