-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 카카오 로그인 구현 및 사용자 인증 방식 개선 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWT를 parsing하여 claim 부분을 반환하는 메서드이기 때문에 적절한 메서드명으로 rename
HS256을 명시적으로 지정하여 사용, secret key의 길이에 따라 선택되는 알고리즘이 달라지는 현상 방지
userId를 return하는 메서드이기때문에 역할에 맞는 메서드명으로 rename
PostConstruct를 통해 인코딩했음에도 다시 인코딩하는 중복 작업 제거
템플릿 메서드 패턴을 통해 공통 로직은 generateJWT에서 정의, 만료 시간(세부 구현)은 generateAccessToken와 generateRefreshToken에 위임
from authorization to Authorization
from generateJWT to generateAccessToken
만료 시 filter chain은 중단: return; 401 UNAUTHORIZED, reissue 요구하는 message로 응답
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
expired access와 expired refresh 구분
valid한 token이 아닌 valid한 refresh로
Kim-TaeUk
commented
Sep 14, 2024
src/main/java/org/websoso/WSSServer/config/jwt/JwtAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
Kim-TaeUk
commented
Sep 14, 2024
src/main/java/org/websoso/WSSServer/config/jwt/JwtAuthenticationFilter.java
Show resolved
Hide resolved
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
src/main/java/org/websoso/WSSServer/oauth2/CustomAuthenticationSuccessHandler.java
Show resolved
Hide resolved
Kim-TaeUk
commented
Sep 14, 2024
Kim-TaeUk
commented
Sep 14, 2024
ChaeAg
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어렵네요 .. 고생많으셨을 것 같습니다
코멘트 조금 달았지만 소소해서 확인만 해주시와요 ~ 🤭
src/main/java/org/websoso/WSSServer/exception/error/CustomAuthError.java
Outdated
Show resolved
Hide resolved
rinarina0429
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
복잡하네요,,, 수고 많으셨습니다 리뷰 한번만 확인해주세요!
src/main/java/org/websoso/WSSServer/config/jwt/JwtAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
To Reviewers