Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 닉네임 유효성 검사 API 응답 변경 #148

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

Kim-TaeUk
Copy link
Contributor

@Kim-TaeUk Kim-TaeUk commented Aug 15, 2024

Related Issue

Key Changes

nickname validation에서 타인 nickname과 중복일 경우 response 변경

To Reviewers

닉네임 유효성 검사 API에서

  1. wooki가 wooki로 유효성 검사하는 경우 -> 400 Bad Request
  2. wooki가 이미 존재하는 nickname인 tuna로 유효성 검사하는 경우 -> 409 Conflict
    였는데

2. 는 유효성을 검사하는 것일 뿐이지 해당 리소스로 put patch post하는 것이 아니기 때문에 409보다는 200이 좋을 것 같다는 클라의 제안에 수정할 예정입니닷

Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 한번만 확인해주세요~

타인 nickname이어서 중복일 때 던지던 409 Conflict 로직 삭제
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

Copy link
Member

@ChaeAg ChaeAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇군요!
조씁니다
수고하셨어용~~!

@Kim-TaeUk Kim-TaeUk merged commit b39e9f4 into dev Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 닉네임 유효성 검사 API 응답 변경
3 participants