Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 타 유저 프로필 조회 기능 구현 #133

Merged
merged 11 commits into from
Aug 8, 2024
Merged

[FEAT] 타 유저 프로필 조회 기능 구현 #133

merged 11 commits into from
Aug 8, 2024

Conversation

Kim-TaeUk
Copy link
Contributor

Related Issue

Key Changes

  • 간단한 API입니다.
  • 프로필 정보에 해당하는 리소스를 response로 반환합니다.

@Kim-TaeUk
[FEAT] 프로필 조회를 위한 엔드포인트 추가
9bed939 
비회원인 경우 User user = null;
@Kim-TaeUk
[FEAT] 프로필 조회를 위한 DTO 추가
ca149ed 
내 프로필인지 나타내는 flag 변수 isMyProfile
@Kim-TaeUk
[FEAT] 프로필 조회를 위한 service 로직 추가
46ccf1b 
내 프로필 조회인 경우 분기 처리
@Kim-TaeUk
[FEAT] white list에 프로필 조회를 위한 엔드포인트 추가
cd953c8 
: /users/profile/{userId}
rinarina0429
rinarina0429 requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 리뷰 확인 부탁드려요!

src/main/java/org/websoso/WSSServer/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/dto/user/ProfileGetResponse.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/dto/user/ProfileGetResponse.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/service/UserService.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/service/UserService.java Outdated Show resolved Hide resolved
@Kim-TaeUk
[REFACTOR] 메서드 시그니처 변경
7847600 
isMyProfile을 첫번째 파라미터로
@Kim-TaeUk
[REFACTOR] 삼항연산자 로직 변수로 분리
44e9129
@Kim-TaeUk
[REMOVE] 사용하지 않는 import문 제거
39768c5
@Kim-TaeUk
[REFACTOR] 본인 프로필인지 확인하는 로직 변수로 분리
f1efad2 
from 확인 후 분기해서 return 처리
to isOwner 변수로 분리하여 of메서드에 아규먼트로 넘기는 방식
@Kim-TaeUk
[REFACTOR] 중복 로직 메서드로 추출
e6f21ea 
avatarRepository에서 avatarId로 조회, 없으면 CustomAvatarException throw
ChaeAg
ChaeAg requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@ChaeAg ChaeAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! 😆
코멘트 하나 남겼어용!

src/main/java/org/websoso/WSSServer/service/UserService.java Outdated Show resolved Hide resolved
@Kim-TaeUk Kim-TaeUk requested a review from ChaeAg August 7, 2024 17:34
@ChaeAg
Copy link
Member

ChaeAg commented Aug 8, 2024

굿입니다!!

@Kim-TaeUk Kim-TaeUk merged commit a428668 into dev Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinarina0429 rinarina0429 rinarina0429 approved these changes

@ChaeAg ChaeAg ChaeAg approved these changes

Assignees

@Kim-TaeUk Kim-TaeUk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 타 유저 프로필 조회 기능 구현
3 participants
@Kim-TaeUk @ChaeAg @rinarina0429