[FEAT] 본인 프로필 수정 기능 구현 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch이기 때문에 Null check 후 set
avatarId nickname - @NicknameConstraint로 validate intro - @SiZe로 최대 제한 길이 validate
avatarId - 이미 설정된 값인지 체크 nickname - 중복 체크, 이미 설정된 값인지 체크 intro - 이미 설정된 값인지 체크
from validateNickname to checkNicknameIfAlreadyExist
isNicknameAvailable() 메서드에서 구현으로 사용하고 있던 로직 checkNicknameIfAlreadyExist()로 대체
제네릭 이용, null이 아니고 기존 값과 동일하다면 exception throw
isNicknameAvailable(), editProfileStatus() 메서드에서 구현으로 사용하고 있던 로직 checkIfAlreadySetOrThrow()로 대체
: ALREADY_SET_NICKNAME, ALREADY_SET_AVATAR, ALREADY_SET_INTRO
from intro to 소개글
PATCH일 때는 null을 허용하기 때문에 null을 허용하는 NicknameConstraint 정의, null일 때는 valid하다고 판단, null이 아닐 때는 NicknameValidator로 validation을 위임
이미 설정한 닉네임인지 확인 후, 다른 유저가 사용 중인 닉네임인지 확인
Kim-TaeUk
commented
Aug 5, 2024
Kim-TaeUk
commented
Aug 5, 2024
Kim-TaeUk
commented
Aug 5, 2024
Kim-TaeUk
commented
Aug 5, 2024
src/main/java/org/websoso/WSSServer/validation/NullAllowedNicknameValidator.java
Show resolved
Hide resolved
ChaeAg
requested changes
Aug 7, 2024
영속성 컨텍스트의 dirty check로 save하지 않아도 db에 반영되므로
from: 조회 후 삭제 to: 조회+삭제 한 번에 수행
rinarina0429
requested changes
Aug 8, 2024
src/main/java/org/websoso/WSSServer/exception/error/CustomUserError.java
Outdated
Show resolved
Hide resolved
rinarina0429
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
checkIfAlreadySetOrThrow())NicknameConstraint는 null check를 하기 때문에NullAllowedNicknameConstraint를 정의했습니다.NicknameConstraint의 validator인NicknameValidator에 validation을 위임합니다.