Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 실시간 인기글 조회 기능 구현 #119

Merged
merged 19 commits into from
Aug 4, 2024
Merged

[FEAT] 실시간 인기글 조회 기능 구현 #119

merged 19 commits into from
Aug 4, 2024

Conversation

Kim-TaeUk
Copy link
Contributor

@Kim-TaeUk Kim-TaeUk commented Jul 28, 2024 •
edited
Loading

Related Issue

Key Changes

  • 실시간 인기글 조회
    • 비회원과 회원 분기 처리했습니다.
    • 차단관계를 고려하여 피드를 조회할 때 JOIN을 쓸까 서브쿼리를 쓸까 고민하다가, QueryDsl을 이용해서 union으로 차단관계에 있는 ID를 얻고, IN 절 서브쿼리로 처리하는 방식을 사용했습니다.
    • 비회원인 경우 차단관계를 고려하지 않아도 되기 때문에 간단하게 상위 9개 레코드를 반환하는 JPA 쿼리 메서드를 호출하도록 했습니다.

References

@Kim-TaeUk Kim-TaeUk marked this pull request as draft July 28, 2024 17:12
@Kim-TaeUk Kim-TaeUk marked this pull request as ready for review July 28, 2024 21:13
ChaeAg
ChaeAg approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@ChaeAg ChaeAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~!

src/main/java/org/websoso/WSSServer/service/PopularFeedService.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/repository/PopularFeedCustomRepositoryImpl.java Show resolved Hide resolved
rinarina0429
rinarina0429 requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! 리뷰 한번씩만 확인 부탁드려요~

src/main/java/org/websoso/WSSServer/controller/FeedController.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/service/PopularFeedService.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/service/PopularFeedService.java Outdated Show resolved Hide resolved
src/main/java/org/websoso/WSSServer/repository/PopularFeedCustomRepositoryImpl.java Show resolved Hide resolved
rinarina0429
rinarina0429 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@rinarina0429 rinarina0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~

@Kim-TaeUk Kim-TaeUk merged commit 32b0566 into dev Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinarina0429 rinarina0429 rinarina0429 approved these changes

@ChaeAg ChaeAg ChaeAg approved these changes

Assignees

@Kim-TaeUk Kim-TaeUk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 실시간 인기글 조회 기능 구현
3 participants
@Kim-TaeUk @rinarina0429 @ChaeAg