-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 오늘 인기작 조회 기능 구현 #115
Conversation
create -> from
ReadStatus가 WATCHING이거나 WATCHED이고, isInterest가 true인 novelId를 내림차순으로 30개(Pageable로 30개 지정)
매일 00시마다 userNovelRepository에서 오늘의 인기작에 해당하는 작품을 30개씩 recentUserNovelRepository에 save
'최근 7일 동안' 조건이 빠져서 추가
전 날 스케쥴링을 통해 얻은 인기 작품들을 영속성 컨텍스트에 올려 두고, 오늘 스케쥴링을 통해 얻은 인기 작품들을 saveAll 한 뒤에 deleteAll 하는 방식
10개보다 많을 때는 랜덤 10개 추출, 10개보다 적을 때는 모두 추출
feed null check 안해주면 feed.getUser()에서 NPE 터짐 -> novel에 해당하는 feed가 없는 경우!
novelId에 해당하는 feed 객체가 null인 경우 filter -> novel에 해당하는 feed가 없는 경우에 NPE 발생하기 때문
src/main/java/org/websoso/WSSServer/dto/popularNovel/PopularNovelGetResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/org/websoso/WSSServer/repository/FeedCustomRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/org/websoso/WSSServer/repository/UserNovelCustomRepositoryImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
코멘트 하나만 확인 부탁드려요!
src/main/java/org/websoso/WSSServer/dto/popularNovel/PopularNovelGetResponse.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!! 리뷰 한번만 확인해주세요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿! 코멘트 반영된 것 확인했습니다!
수고하셨습니다~!
from popularNovelIds to novelIdsFromPopularNovel
from selectedPopularNovelIds to selectedNovelIdsFromPopularNovel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~!!
Related Issue
Key Changes
To Reviewers