Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 작품평가 수정 API 구현 #107

Merged
merged 31 commits into from
Aug 4, 2024
Merged

[FEAT] 작품평가 수정 API 구현 #107

merged 31 commits into from
Aug 4, 2024

Conversation

rinarina0429
Copy link
Contributor

Related Issue

Key Changes

작품평가를 수정하는 API를 구현했습니다.

  • 작품평가 조회, 생성, 수정의 함수명이 기존에는 deleteUserNovel(), updateUserNovel()과 같은 방식이었는데 작품평가 삭제의 경우, 관심으로 등록이 되어있으면 평가만 초기화될 뿐 UserNovel이 삭제되는게 아니라 어색하다고 느껴서 deleteEvaluation(), updateEvaluation() 등으로 수정했습니다.

To Reviewers

References

@rinarina0429 rinarina0429 self-assigned this Jul 17, 2024
ChaeAg
ChaeAg approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@ChaeAg ChaeAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니당 !! ><

src/main/java/org/websoso/WSSServer/repository/UserNovelAttractivePointRepository.java Outdated Show resolved Hide resolved
Kim-TaeUk
Kim-TaeUk requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@Kim-TaeUk Kim-TaeUk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 코멘트 남겨두었습니다. 좀 많이 ㅎㅎ

@Kim-TaeUk Kim-TaeUk mentioned this pull request Aug 4, 2024
Merged
@rinarina0429 rinarina0429 merged commit 07df30e into dev Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kim-TaeUk Kim-TaeUk Kim-TaeUk approved these changes

@ChaeAg ChaeAg ChaeAg approved these changes

Assignees

@rinarina0429 rinarina0429

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 작품평가 수정 API 구현
3 participants
@rinarina0429 @Kim-TaeUk @ChaeAg