Skip to content

Commit

Permalink
[REFACTOR] 함수명 교체
Browse files Browse the repository at this point in the history
  • Loading branch information
rinarina0429 committed May 19, 2024
1 parent 298aaf9 commit 386ae89
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class KeywordController {
private final KeywordService keywordService;

@GetMapping
public ResponseEntity<KeywordByCategoryGetResponse> getKeywordsByCategory(@RequestParam(required = false) String query) {
return ResponseEntity.ok(keywordService.getAll(query));
public ResponseEntity<KeywordByCategoryGetResponse> searchKeywordByCategory(@RequestParam(required = false) String query) {
return ResponseEntity.ok(keywordService.searchKeywordByCategory(query));
}
}
18 changes: 9 additions & 9 deletions src/main/java/org/websoso/WSSServer/service/KeywordService.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class KeywordService {

private final KeywordRepository keywordRepository;

public List<KeywordGetResponse> searchKeywordsByCategory(String query, KeywordCategory keywordCategory) {
public List<KeywordGetResponse> searchKeyword(String query, KeywordCategory keywordCategory) {
List<Keyword> searchedKeyword;

if (query == null || query.isEmpty()) {
Expand All @@ -38,22 +38,22 @@ public List<KeywordGetResponse> searchKeywordsByCategory(String query, KeywordCa
.collect(Collectors.toList());
}

public List<CategoryGetResponse> getCategorys(String query) { //TODO 반복적인 코드 줄이기
public List<CategoryGetResponse> sortByCategory(String query) { //TODO 반복적인 코드 줄이기
CategoryGetResponse worldview = CategoryGetResponse.of(KeywordCategory.WORLDVIEW,
searchKeywordsByCategory(query, KeywordCategory.WORLDVIEW));
searchKeyword(query, KeywordCategory.WORLDVIEW));
CategoryGetResponse material = CategoryGetResponse.of(KeywordCategory.MATERIAL,
searchKeywordsByCategory(query, KeywordCategory.MATERIAL));
searchKeyword(query, KeywordCategory.MATERIAL));
CategoryGetResponse character = CategoryGetResponse.of(KeywordCategory.CHARACTER,
searchKeywordsByCategory(query, KeywordCategory.CHARACTER));
searchKeyword(query, KeywordCategory.CHARACTER));
CategoryGetResponse relationship = CategoryGetResponse.of(KeywordCategory.RELATIONSHIP,
searchKeywordsByCategory(query, KeywordCategory.RELATIONSHIP));
searchKeyword(query, KeywordCategory.RELATIONSHIP));
CategoryGetResponse vibe = CategoryGetResponse.of(KeywordCategory.VIBE,
searchKeywordsByCategory(query, KeywordCategory.VIBE));
searchKeyword(query, KeywordCategory.VIBE));
return Arrays.asList(worldview, material, character, relationship, vibe);
}

public KeywordByCategoryGetResponse getAll(String query) { //TODO 함수 이름
List<CategoryGetResponse> categorys = getCategorys(query);
public KeywordByCategoryGetResponse searchKeywordByCategory(String query) { //TODO 함수 이름
List<CategoryGetResponse> categorys = sortByCategory(query);
return KeywordByCategoryGetResponse.of(categorys);
}
}

0 comments on commit 386ae89

Please sign in to comment.